[gt-users] A series of questions regarding GenomeTools C and its Python interface

[Brent Pedersen]

On Mon, Apr 27, 2009 at 7:57 AM, James Casbon <casbon at gmail.com> wrote:
> 2009/4/27 Sascha Steinbiss <steinbiss at zbh.uni-hamburg.de>:
>> The Python bindings to the whole of GenomeTools are by no means
>> complete. Most of the existing bindings cover the AnnotationSketch
>> visualisation library and its dependencies. However, we are always glad
>> to accept contributions ;)
>
> I have a couple of itches to scratch about the python bindings which I
> had not been mentioning until now...
>
> Firstly, python code should be indented with four spaces.  The python
> style guide - http://www.python.org/dev/peps/pep-0008/ - says:
> "Use 4 spaces per indentation level."
> It's unequivocal.  I might knock up a patch if you indicate it would
> be accepted.

+1. this would make it easier to submit patches. currently, i have to
either manually
dedent from 4 spaces or turn off python mode in my editor.

>
> Secondly, what's with all this obj._as_parameter and from_param stuff?
>  You seem to be putting a classmethod in every class to return an
> object variable.  Just access the variable.  The other thing
> from_parameter does is check the object is the correct class.   I'm
> not sure why you are doing this - to ensure the type of
> _as_parameter_?
>
>
> cheers,
> James
> _______________________________________________
> gt-users mailing list
> gt-users at genometools.org
> http://genometools.org/mailman/listinfo/gt-users
>